Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault Certificates] Generated code update (9726 9069 9590) #9733

Closed

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Jun 26, 2020

IMPORTANT:
Based on the latest meeting notes, we won't be releasing any related to 7.2 on July. This PR can wait.

This PR attempts to:

  • Move the generated folders from core to generated.
  • Use Autorest TypeScript v6. Not anymore!
  • Use KeyVault's swagger files for the 7.2-preview service version.

All of this in Key Vault Certificates client ONLY.

IMPORTANT: This requires re-generating some recordings. I'll do that after we merge: #9693

One this looks good, I'll do the same for Secrets and Certificates.

For #9726
For #9069
For #9590 Not anymore!

@sadasant sadasant self-assigned this Jun 26, 2020
@sadasant
Copy link
Contributor Author

One good thing from this PR: I believe the lack of changes in the review/ file shows that the changes aren't breaking. It increases my confidence.

One bad thing about this PR: The generated code has naming inconsistencies, and the convenience layer feels like it could have some refactoring. I don't think I have budget for neither of those at the moment though.

@sadasant
Copy link
Contributor Author

Since #9726 is not intended for July, I'll close this PR. It will be easy to re-do this for September.

@sadasant sadasant closed this Jun 27, 2020
@sadasant sadasant deleted the keyvault/9726-9069-9590-certificates branch June 27, 2020 12:10
@sadasant sadasant restored the keyvault/9726-9069-9590-certificates branch June 27, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants